Merge branch 'next' into feat-convert-legacy-parameters-to-rules

Author: Monsterovich

.clang-tidy

@@ -14,7 +14,6 @@ Checks: >
   -readability-magic-numbers,
   -readability-identifier-length,
   -bugprone-easily-swappable-parameters
-AnalyzeTemporaryDtors: false
 FormatStyle:     file
 CheckOptions:
   - key: readability-magic-numbers.IgnoredIntegerValues
@@ -29,3 +28,5 @@ CheckOptions:
     value: true
   - key: bugprone-signed-char-misuse.CharTypdefsToIgnore
     value: int8_t
+  - key: bugprone-suspicious-string-compare.WarnOnLogicalNotComparison
+    value: true

.github/workflows/codeql-analysis.yml

@@ -34,7 +34,7 @@ jobs:
         languages: ${{ matrix.language }}
 
     # Install dependencies
-    - run: sudo apt update && sudo apt install libdbus-1-dev libegl-dev libev-dev libgl-dev libpcre2-dev libpixman-1-dev libx11-xcb-dev libxcb1-dev libxcb-composite0-dev libxcb-damage0-dev libxcb-glx0-dev libxcb-image0-dev libxcb-present-dev libxcb-randr0-dev libxcb-render0-dev libxcb-render-util0-dev libxcb-shape0-dev libxcb-util-dev libxcb-xfixes0-dev meson ninja-build uthash-dev
+    - run: sudo apt update && sudo apt install libdbus-1-dev libegl-dev libev-dev libgl-dev libpcre2-dev libpixman-1-dev libx11-xcb-dev libxcb1-dev libxcb-composite0-dev libxcb-damage0-dev libxcb-glx0-dev libxcb-image0-dev libxcb-present-dev libxcb-randr0-dev libxcb-render0-dev libxcb-render-util0-dev libxcb-shape0-dev libxcb-util-dev libxcb-xfixes0-dev meson ninja-build uthash-dev libepoxy-dev
       if: ${{ matrix.language == 'cpp' }}
 
     # Autobuild

.github/workflows/coding-style-pr.yml

@@ -8,6 +8,6 @@ jobs:
     steps:
     - uses: actions/checkout@v4
     - run: git fetch --depth=1 origin ${{ github.event.pull_request.base.sha }}
-    - uses: yshui/git-clang-format-lint@v1.16
+    - uses: yshui/git-clang-format-lint@v1.17
       with:
         base: ${{ github.event.pull_request.base.sha }}

.github/workflows/coding-style.yml

@@ -9,6 +9,6 @@ jobs:
     - uses: actions/checkout@v4
       with:
         fetch-depth: 2
-    - uses: yshui/git-clang-format-lint@v1.16
+    - uses: yshui/git-clang-format-lint@v1.17
       with:
         base: ${{ github.event.ref }}~1

CHANGELOG.md

@@ -1,10 +1,84 @@
+# Unreleased
+
+## Deprecations
+
+* `--legacy-backends` is now deprecated. Setting it no longer has an effect.
+* `resize-damage`, `glx-no-stencil` and `glx-no-rebind-pixmap` are now deprecated, because they only works on legacy backends.
+* Removed several options that have been deprecated for a long time, this includes:
+  - `glx-fshader-win`
+  - `glx-swap-method`
+  - `glx-use-gpushader4`
+  - `menu-opacity`
+  - `vsync-aggressive`
+  - `respect-prop-shadow`
+  - `sw-opti`
+  - `clear-shadow`
+
+# 12.3 (2024-Oct-14)
+
+## Improvements
+
+* Extend workaround for missing hardware accelerated convolution to more drivers (#1349)
+
+## Bug fixes
+
+* Fix memory corruption that can happen when handling window property changes (#1350)
+* Fix `force-win-blend` having no effect (#1354)
+* Fix shadow being rendered incorrectly in xrender backend (#1352)
+
+# 12.2 (2024-Oct-10)
+
+## Improvements
+
+* fly-out/slide-out animation presets no longer cause jumps in window opacity
+
+## Bug fixes
+
+* Random delays before screen is updated (#1345 #1330)
+* Fix building on 32-bit systems (#1346)
+* Fix blank screen on 32-bit systems
+* Fix fly-in/fly-out animation presets so they work with directions other than up and left
+
+# v12.1 (2024-Sep-29)
+
+## Bug fixes
+
+* picom stops rendering correctly after monitor configuration changes (#1338, thanks to @Suyooo)
+
+# v12 (2024-Sep-27)
+
+## Bug fixes
+
+* Fix crash related to window leader updates (#1337 + extra).
+* Remove an invalid assertion.
+
+# v12-rc4 (2024-Sep-08)
+
+## Bug fixes
+
+* Windows become completely black when `rules` and `inactive-dim` are set at the same time
+* Fix segmentation fault during unredirection if the geometry change animation is used (#1333, thanks to @monsterovich)
+* Fix many rare race conditions in the window management code (#1334)
+
+# v12-rc3 (2024-Aug-30)
+
+## Bug fixes
+
+* `transparent-clipping` has no effect (#1317)
+* `unredir` in window rules not being parsed correctly
+* Changing window opacity with `picom-trans` does not take effect immediately (#1315)
+
+## Documentation
+
+* Document behavior change around rounded corners and fullscreen windows (#1323)
+
 # v12-rc2 (2024-Aug-17)
 
 ## Bug fixes
 
-* Setting corner-radius to 0 cause all windows to not render: #1311
+* Setting corner-radius to 0 cause all windows to not render (#1311)
 * Setting corner-radius causes windows to have a 1-pixel transparent border
-* Window shaders no longer work: #1312
+* Window shaders no longer work (#1312)
 
 # v12-rc1 (2024-Aug-12)
 

CONTRIBUTORS

@@ -80,6 +80,7 @@ scrouthtv <lennivh24 at gmail.com>
 Sebastien Waegeneire <sebastien at waegeneire.com>
 Stefan Radziuk <stefan.radziuk19 at imperial.ac.uk>
 Subhaditya Nath <sn03.general at gmail.com>
+Suyooo <me at suyo.be>
 Tasos Sahanidis <tasos at tasossah.com>
 Thiago Kenji Okada <thiagokokada at gmail.com>
 Tilman Sauerbeck <tilman at code-monkey.de>

README.md

@@ -53,10 +53,10 @@ libconfig-dev libdbus-1-dev libegl-dev libev-dev libgl-dev libepoxy-dev libpcre2
 On Fedora, the needed packages are
 
 ```
-dbus-devel gcc git libconfig-devel libdrm-devel libev-devel libX11-devel libX11-xcb libxcb-devel libGL-devel libEGL-devel libepoxy-devel meson pcre2-devel pixman-devel uthash-devel xcb-util-image-devel xcb-util-renderutil-devel xorg-x11-proto-devel xcb-util-devel
+dbus-devel gcc git libconfig-devel libev-devel libX11-devel libX11-xcb libxcb-devel libGL-devel libEGL-devel libepoxy-devel meson pcre2-devel pixman-devel uthash-devel xcb-util-image-devel xcb-util-renderutil-devel xorg-x11-proto-devel xcb-util-devel
 ```
 
-To build the documents, you need `asciidoc`
+To build the documents, you need `asciidoctor`
 
 ### To build
 

data/animation_presets.conf

@@ -71,7 +71,11 @@ slide-out = {
     crop-y = "window-y";
     crop-width = "window-width";
     crop-height = "window-height";
-    opacity = 1;
+    opacity = {
+        start = "window-raw-opacity-before";
+        end = "window-raw-opacity-before";
+        duration = "placeholder0";
+    };
     blur-opacity = "opacity";
     shadow-opacity = "opacity";
     *knobs = {
@@ -118,49 +122,54 @@ fly-out = {
         curve = "cubic-bezier(0.05, 0, 0.69, -0.05)";
         duration = "placeholder0";
         start = 0;
-        end = "(window-height + window-y) * placeholder2 + (window-width + window-x) * placeholder1";
+        end = "window-height * placeholder2 + window-y * placeholder5 + window-width * placeholder1 + window-x * placeholder4";
     };
     offset-x = "v-timing * placeholder3";
     offset-y = "v-timing * (1 - placeholder3)";
     shadow-offset-x = "offset-x";
     shadow-offset-y = "offset-y";
-    opacity = 1;
-    shadow-opacity = 1;
-    blur-opacity = 1;
+    opacity = {
+        start = "window-raw-opacity-before";
+        end = "window-raw-opacity-before";
+        duration = "placeholder0";
+    };
+    shadow-opacity = "opacity";
+    blur-opacity = "opacity";
     *knobs = {
         duration = 0.2;
         direction = (0, ["up", "down", "left", "right"]);
     };
     *placeholders = (
         (0, "duration"),
-        (1, "direction", [0, 0, -1, 1]),
-        (2, "direction", [-1, 1, 0, 0]),
-        (3, "direction", [0, 0, 1, 1]),
+        (1, "direction", [0, 0, -1, 1]), # left/right -> +1/-1 for X axis
+        (2, "direction", [-1, 1, 0, 0]), # up/down -> +1/-1 for Y axis
+        (3, "direction", [0, 0, 1, 1]),  # X/Y axis switch
+        (4, "direction", [0, 0, -1, 0]),  # whether window X is added
+        (5, "direction", [-1, 0, 0, 0]),  # whether window Y is added
     );
 };
 fly-in = {
     v-timing = {
         curve = "cubic-bezier(0.17, 0.67, 0.68, 1.03)";
         end = 0;
         duration = "placeholder0";
-        start = "- window-height - window-y";
+        start = "window-height * placeholder2 + window-y * placeholder5 + window-width * placeholder1 + window-x * placeholder4";
     };
     offset-x = "v-timing * placeholder3";
     offset-y = "v-timing * (1 - placeholder3)";
     shadow-offset-x = "offset-x";
     shadow-offset-y = "offset-y";
-    opacity = 1;
-    shadow-opacity = 1;
-    blur-opacity = 1;
     *knobs = {
         duration = 0.2;
         direction = (0, ["up", "down", "left", "right"]);
     };
     *placeholders = (
         (0, "duration"),
-        (1, "direction", [0, 0, -1, 1]),
-        (2, "direction", [-1, 1, 0, 0]),
-        (3, "direction", [0, 0, 1, 1]),
+        (1, "direction", [0, 0, -1, 1]), # left/right -> +1/-1 for X axis
+        (2, "direction", [-1, 1, 0, 0]), # up/down -> +1/-1 for Y axis
+        (3, "direction", [0, 0, 1, 1]),  # X/Y axis switch
+        (4, "direction", [0, 0, -1, 0]),  # whether window X is added
+        (5, "direction", [-1, 0, 0, 0]),  # whether window Y is added
     );
 };
 geometry-change = {

man/meson.build

@@ -2,18 +2,32 @@ mans = ['picom.1', 'picom-inspect.1', 'picom-trans.1']
 if get_option('with_docs')
 	a2x = find_program('asciidoctor')
 	foreach m : mans
-		custom_target(m, output: [m], input: [m+'.adoc'],
-		              command: [a2x, '-a',
-		                        'picom-version='+version,
-		                        '--backend', 'manpage', '@INPUT@', '-D',
-		                        meson.current_build_dir()],
-		              install: true,
-		              install_dir: join_paths(get_option('mandir'), 'man1'))
-		custom_target(m+'.html', output: [m+'.html'], input: [m+'.adoc'],
-		              command: [a2x, '-a',
-		                        'picom-version='+version,
-		                        '--backend', 'html', '@INPUT@', '-D',
-		                        meson.current_build_dir()],
-		              install_dir: get_option('datadir') / 'doc' / 'picom')
+		custom_target(
+			m,
+			output: [m],
+			input: [m + '.adoc'],
+			command: [
+				a2x,
+				'-a', 'picom-version=v' + meson.project_version(),
+				'--backend', 'manpage',
+				'@INPUT@',
+				'-D', meson.current_build_dir(),
+			],
+			install: true,
+			install_dir: join_paths(get_option('mandir'), 'man1'),
+		)
+		custom_target(
+			m + '.html',
+			output: [m + '.html'],
+			input: [m + '.adoc'],
+			command: [
+				a2x,
+				'-a', 'picom-version=v' + meson.project_version(),
+				'--backend', 'html',
+				'@INPUT@',
+				'-D', meson.current_build_dir(),
+			],
+			install_dir: get_option('datadir') / 'doc' / 'picom',
+		)
 	endforeach
 endif