Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI column type search doesn't work with enter #768

Closed
Arustinal opened this issue Sep 15, 2024 · 3 comments
Closed

UI column type search doesn't work with enter #768

Arustinal opened this issue Sep 15, 2024 · 3 comments
Assignees

Comments

@Arustinal
Copy link

You can't use enter for data type selector in UI.
There's 2 problems - no autofocus on first search result and unexpected reaction for enter button. It's look like enter is applied to folders and tables, not create table menu.

How to reproduce:

  1. Start create table from UI
  2. Go to column selector
  3. Try to select data type by typing into field
  4. Hit enter
@Kontakter Kontakter transferred this issue from ytsaurus/ytsaurus Sep 17, 2024
@Kontakter
Copy link

@ma-efremoff – could you please take a look at this issue

@vrozaev
Copy link
Collaborator

vrozaev commented Sep 20, 2024

SIG UI Weekly discussion:

Yes, we do need fix that and check that we can use dialogs via keyboard, focus should not leave dialog.

And at least enter and escape should work.

@vrozaev vrozaev self-assigned this Feb 7, 2025
vrozaev added a commit that referenced this issue Feb 12, 2025
vrozaev added a commit that referenced this issue Feb 12, 2025
vrozaev added a commit that referenced this issue Feb 12, 2025
vrozaev added a commit that referenced this issue Feb 12, 2025
vrozaev added a commit that referenced this issue Feb 12, 2025
vrozaev added a commit that referenced this issue Feb 12, 2025
vrozaev added a commit that referenced this issue Feb 12, 2025
@vrozaev
Copy link
Collaborator

vrozaev commented Feb 12, 2025

Fixed in #992

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants