Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce consistent string literal quoting style with single quotes #3293

Open
robertcheramy opened this issue Oct 16, 2024 · 1 comment
Open
Assignees
Milestone

Comments

@robertcheramy
Copy link
Collaborator

We currently have a mixed string literal quoting style. The overwhelming majority of the code use single quotes, so I plan to enforce single quote with rubocop. This can inly be done when we have no open PRs because it could produce merge conflicts.

Rubystyle: https://rubystyle.guide/#consistent-string-literals-single-quote
Rubocop: https://docs.rubocop.org/rubocop/cops_style.html#stylestringliterals

@robertcheramy robertcheramy added this to the 0.31 milestone Oct 16, 2024
@robertcheramy robertcheramy self-assigned this Oct 16, 2024
@robertcheramy
Copy link
Collaborator Author

Moving to milestone 0.32 - this is a big change and I don't want to do it shortly before a release.

@robertcheramy robertcheramy modified the milestones: 0.31, 0.32 Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant