Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DocDB] Vector index compaction support in yb-admin #26332

Closed
1 task done
arybochkin opened this issue Mar 10, 2025 · 0 comments
Closed
1 task done

[DocDB] Vector index compaction support in yb-admin #26332

arybochkin opened this issue Mar 10, 2025 · 0 comments
Assignees
@arybochkin
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@arybochkin
Copy link
Contributor

arybochkin commented Mar 10, 2025 •
edited by jira bot
Loading

Jira Link: DB-15678

Description

It is required to update yb-admin compact_table and yb_admin flush_table to support correct compaction and flush when the command is triggered for the vector index table and not the indexable table.

Issue Type

kind/enhancement

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@arybochkin arybochkin added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Mar 10, 2025
@arybochkin arybochkin self-assigned this Mar 10, 2025
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue and removed status/awaiting-triage Issue awaiting triage labels Mar 10, 2025
arybochkin added a commit that referenced this issue Mar 10, 2025
@arybochkin
[#26332] docdb: Vector index compaction support in yb-admin
12d3543 
Summary:
The code base is updated to allow vector index compaction be triggered by the following command:
```
yb-admin compact_table <vector index name>
yb-admin compact_table_by_id <vector index id>
```
These commands trigger only vector index compaction and no compaction is triggered for the indexable
table. On the other hand, triggering compaction on the indexable table will not trigger compaction on
vector indexes -- this approach is selected to prevent undesirable effects of long vector index
compactions (because they are not yet optimized).

Additionally, `yb-admin flush_table <vector index>` is changed to trigger a flush only for vector
index and no flushes are triggered for the indexable table. Previously, the given command was
acting as if the flush was triggered for the indexable table.

**Upgrade/Rollback safety:**
It is safe to upgrade and rollback as the feature is not released. Also the presence of the values
are ignored by old releases which is acceptable behaviour (same is without the change).
Jira: DB-15678

Test Plan: Jenkins

Reviewers: sergei, slingam

Reviewed By: sergei

Subscribers: ybase

Differential Revision: https://phorge.dev.yugabyte.com/D42404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arybochkin arybochkin

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yugabyte-ci @arybochkin