-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compile errors in kobuki_gazebo_plugins with Kinetic and Gazebo7 #45
Conversation
Gazebo 7 uses std::shared_ptr so the cast needs to be from std not boost
This looks good. I created the kinetic branch off jade. Could you resend this PR to the kinetic branch? |
Thanks @rohbotics, these changes allowed me to compile Kobuki, although it seems I have not been receiving the same errors as others. For one, I never received an error message requiring C++11 to be declared (like in #44), so I didn't modify my CMakeList.txt file. I also received error messages referring to deprecated functions GetRange() and GetContact() - I fixed these by removing 'Get' from their names to put them in accordance to their current names (I found this link useful in finding their current names). Edit: I just realized that the GetRange() and GetContact() messages are warnings, not errors. The changes I've made in the .cpp code to remove these warnings still allowed Kobuki to build. |
@cerebro-deux What platform are you running on (OS, ROS version, Arch) ? Thanks for the link, I will try to see if I can get rid of some of the warnings on the build. |
@rohbotics I'm using Ubuntu Xenial, with ROS Kinetic. I've built Kobuki (and TurtleBot) following the instructions here, of course with your fixes. ROS and Gazebo were installed using apt-get in Ubuntu, but Rocon, Kobuki and TurtleBot were built from source. |
@cerebro-deux, It's interesting that you are not getting the compiler error about C++11 features, I tried on a fresh install of Xenial, and the first error in the log was
Maybe you have a non-default version of gcc, but I am not sure. |
@rohbotics - Yes, I have a fresh install of Xenial too. This is what came out of gcc --version: In any case, Kobuki and Turtlebot were able to build. |
Kinetic moved to Gazebo7 which requires c++11 and has many changes to the API, this pull request makes koubki_gazebo_plugins compile with no errors on kinetic and Ubuntu 16.04.
This should be pulled into a separate branch for kinetic.