Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cll.cpp fails to compile #31

Open
yukarpenko opened this issue Nov 22, 2024 · 2 comments
Open

cll.cpp fails to compile #31

yukarpenko opened this issue Nov 22, 2024 · 2 comments
Assignees

Comments

@yukarpenko
Copy link
Owner

hi Nils! [testing the way of communicating fixes via "Issues" on Github] -- it seems that with GCC 12.2 and possibly GCC 14, the recent addition you've made prevent cll.cpp from being successfully compiled. With GCC 11, it still looks ok.
I've realised it might be an issue indeed, as std::vector is used in type declarations in cll.h, but #include is not there yet.
So as a temporary fix, I tried adding #include in cll.h, and it fixes the compilation issue -- would this fix look consistent to you?

@nilssass
Copy link
Collaborator

Hi Iurii, indeed I did not realize that I have missed the #include <vector> in cll.h. I am wondering why I did not run into this issue, even with the missing include directive, but you are right, to fix this issue, one needs to add #include <vector> in cll.h. Do you want me to open a PR for it?

@yukarpenko
Copy link
Owner Author

hi Nils - please don't open the PR just yet. I'll ask a colleague of mine who uses GCC 14 and apparently has issues not only with cll.h btut other files. My understanding is that including and other "standard" headers in header files is ok, so it should be an easy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants