From d4c4adbff68303cb0b7857e335f4976127b76542 Mon Sep 17 00:00:00 2001
From: Yohei Yukawa <yukawa@chromium.org>
Date: Tue, 19 Nov 2024 17:31:07 +0900
Subject: [PATCH] Remove unused entries from `common_win.gypi`

This is a trivial code cleanup commit to remove unused entries from
common_win.gypi.

There must be no behavior change in the final artifacts.
---
 src/gyp/common_win.gypi | 34 ----------------------------------
 1 file changed, 34 deletions(-)

diff --git a/src/gyp/common_win.gypi b/src/gyp/common_win.gypi
index 9aef86028..3383b3a1b 100644
--- a/src/gyp/common_win.gypi
+++ b/src/gyp/common_win.gypi
@@ -43,11 +43,6 @@
     # Visual C++ Runtime Version.
     'vcruntime_ver%': '',
 
-    # Extra headers and libraries for Visual C++.
-    'msvs_includes%': [],
-    'msvs_libs_x86%': [],
-    'msvs_libs_x64%': [],
-
     'conditions': [
       # https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros
       ['MSVS_VERSION=="2015"', {
@@ -131,25 +126,11 @@
               '/bigobj',
             ],
           },
-          'VCLibrarianTool': {
-            'AdditionalLibraryDirectories': [
-              '<@(msvs_libs_x86)',
-            ],
-            'AdditionalLibraryDirectories!': [
-              '<@(msvs_libs_x64)',
-            ],
-          },
           'VCLinkerTool': {
             'TargetMachine': '<(win_target_machine_x86)',
             'AdditionalOptions': [
               '/SAFESEH',
             ],
-            'AdditionalLibraryDirectories': [
-              '<@(msvs_libs_x86)',
-            ],
-            'AdditionalLibraryDirectories!': [
-              '<@(msvs_libs_x64)',
-            ],
             'EnableUAC': 'true',
             'UACExecutionLevel': '0',  # level="asInvoker"
             'UACUIAccess': 'false',    # uiAccess="false"
@@ -175,22 +156,8 @@
               '/bigobj',
             ],
           },
-          'VCLibrarianTool': {
-            'AdditionalLibraryDirectories': [
-              '<@(msvs_libs_x64)',
-            ],
-            'AdditionalLibraryDirectories!': [
-              '<@(msvs_libs_x86)',
-            ],
-          },
           'VCLinkerTool': {
             'TargetMachine': '<(win_target_machine_x64)',
-            'AdditionalLibraryDirectories': [
-              '<@(msvs_libs_x64)',
-            ],
-            'AdditionalLibraryDirectories!': [
-              '<@(msvs_libs_x86)',
-            ],
           },
         },
       },
@@ -332,7 +299,6 @@
       '<@(absl_include_dirs)',
       '<(abs_depth)',
       '<(SHARED_INTERMEDIATE_DIR)',
-      '<@(msvs_includes)',
       '<(third_party_dir)/wil/include',
     ],
     'msvs_configuration_attributes': {