Skip to content

Commit

Permalink
Remove certificate secret from workflows and Dockerfile
Browse files Browse the repository at this point in the history
The certificate secret reference was removed from the GitHub workflows and the Dockerfile. This was done to secure and protect sensitive data, as we no longer want to expose the certificate as part of our Continuous Integration and Continuous Deployment pipelines.
  • Loading branch information
bgharbi-globalpos committed Feb 7, 2024
1 parent 1195d6e commit 671fc88
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/miigration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,5 +39,3 @@ jobs:
push: true
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
secrets: |
"certificate=${{ secrets.CERTIFICATE }}"
2 changes: 0 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ FROM node:16.18.0

ADD . /app
WORKDIR /app
RUN --mount=type=secret,id=certificate \
cat /run/secrets/certificate >> /app/ca-certificate.crt

RUN yarn install && yarn build

Expand Down

0 comments on commit 671fc88

Please sign in to comment.