Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Other]: Remove the MelonLoader net6preview build #40

Open
slxdy opened this issue Dec 25, 2024 · 9 comments
Open

[Other]: Remove the MelonLoader net6preview build #40

slxdy opened this issue Dec 25, 2024 · 9 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@slxdy
Copy link

slxdy commented Dec 25, 2024

Describe the issue

Since this build was only used for indev 0.6 versions, it is no longer needed and only serves as a confusion for the user

@yukieiji
Copy link
Owner

yukieiji commented Dec 25, 2024

It may indeed confuse users, but I think it is necessary since v6.0.0 Alpha has been released on GitHub.

@slxdy
Copy link
Author

slxdy commented Dec 25, 2024

It is completely unsupported in the community, and no one is or should be using it. Otherwise, I suggest to rename the UE build to specify the ML version it targets

@yukieiji
Copy link
Owner

yukieiji commented Dec 25, 2024

It is completely unsupported in the community, and no one is or should be using it

If I remove this because the community doesn't support it, then I must also remove the old version of BepInEx, otherwise it will not add up.
Also, I don't think you can prove that no one is using it.

Otherwise, I suggest to rename the UE build to specify the ML version it targets

Is it mentioned in the README, but that is not enough?
Those who don't read such README probably won't change even if I rename the release.

@yukieiji
Copy link
Owner

I think it would be better to show that this is for ML v6.0.0 Alpha when the assembly load error occurs, rather than changing the release name.

@slxdy
Copy link
Author

slxdy commented Dec 25, 2024

That's also fine, as long as the user is aware they're using the wrong version. We get a lot of reports with people attempting to run the net6preview build on the wrong version. I also suggest implementing a check before initializing the mod, as it often results in initializing on the wrong version and throwing a ton of errors.

Also, I don't think you can prove that no one is using it.

The release is very unstable and no one should be using it. We are actively discouraging people from using this release (which almost never happens regardless). The release was only meant as a test for the full release of CoreCLR and a warning for mod developers to update their mods before the full release

@yukieiji
Copy link
Owner

yukieiji commented Dec 25, 2024

That's also fine, as long as the user is aware they're using the wrong version. We get a lot of reports with people attempting to run the net6preview build on the wrong version.

This is a problem of user understanding, and I feel that it's wrong to try to solve the problem only by the developers, including myself(There is even a possibility of using CoreCLR build in ML 6.0.0 Alpha)

I also suggest implementing a check before initializing the mod, as it often results in initializing on the wrong version and throwing a ton of errors.

The initialization process shouldn't have even been called because it failed at the point of loading the UE DLL.
UniverseLib is executed up to the initialization process, so it is possible to implement warnings, etc., but I think that eventually there will be reports of “UE, etc., not being displayed”.

The release is very unstable and no one should be using it. We are actively discouraging people from using this release (which almost never happens regardless). The release was only meant as a test for the full release of CoreCLR and a warning for mod developers to update their mods before the full release

As a mod developer, I understand that, but the user may not necessarily understand it.

The best solution would probably be to remove (or empty) the v6.0.0 Alpha release of ML, notify that it is deprecated, and remove the net6preview build.

@yukieiji
Copy link
Owner

If ML v6.0.0 Alpha has been deleted, I will gladly remove net6preview build

@yukieiji yukieiji added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 25, 2024
@slxdy
Copy link
Author

slxdy commented Dec 25, 2024

I don't think removing the version is a good idea, but a warning for the user would be great. Maybe it would be worth removing the net6preview build once MelonLoader v1.0 is released?

Either way, thanks for the consideration

@yukieiji
Copy link
Owner

Maybe it would be worth removing the net6preview build once MelonLoader v1.0 is released?

I think that even if v1.0.0 of ML is released, this problem willn't be solved as long as users can DL either ML v6.0.0 Alpha or UE net6preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants