Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform Provider Development, Final Review #176

Open
5 tasks
cgriggs01 opened this issue Apr 1, 2019 · 0 comments
Open
5 tasks

Terraform Provider Development, Final Review #176

cgriggs01 opened this issue Apr 1, 2019 · 0 comments
Assignees

Comments

@cgriggs01
Copy link

Hi Team,

Thank you for your patience throughout this provider review process. We have outlined a few more items of feedback that should be address before moving on to the provider release. If you have any questions regarding this feedback, let me know.

  • In the providers website documentation index page argument reference, the access_key and secret_key variables are listed as optional, if I'm not confused, these variables should be listed as Required.

  • On the Instance resource documentation page, the argument references for variables with a default value should document that value. Specially for the CPU, Memory, and Class variables, as well the keypair_id argument is listed as Required but is defined in the provider code as Optional.

  • On the Tag resource docs , could you add the DEFAULT_TAG_COLOR env variable to the color argument reference.

  • In the VPC resource documentation, can you list the default value for the type argument?

  • The last item is to add more debug statements throughout the provider. Ideally we would like to have two [INFO] statements during each resource operation. This is not a hard requirement, but highly suggested.

These issue should take too long to address. Once complete we can move forward to the ingress and release process of this provider.

Best,
Chris

@runzexia runzexia self-assigned this Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants