Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run incorrrectly marked as successful if git push fails #6

Open
emab opened this issue Apr 11, 2023 · 1 comment
Open

Run incorrrectly marked as successful if git push fails #6

emab opened this issue Apr 11, 2023 · 1 comment

Comments

@emab
Copy link
Contributor

emab commented Apr 11, 2023

When the push is attempted, a successful push is detected by looking for references of the word remote. This doesn't work as the word also appears when the push fails, for example:

image

Expected behaviour is that the run is marked as failed if any push fails.

@emab emab changed the title Run marked as successful if git push fails Run incorrrectly marked as successful if git push fails Apr 11, 2023
@emab
Copy link
Contributor Author

emab commented Apr 11, 2023

const processKillTriggerWords = [
"building source",
"remote",
"compressing source files",
];

Fix should be relatively straightforward if these kill trigger words are updated. Perhaps some trigger words that trigger a failure would be useful, such as rejected. That way any failures will be picked up before assuming it's a successful push.

For reference, when pushing to Heroku, the output includes remote: after the push has been successful which is why it was used originally.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant