Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: remember selected subtitle index when changing files #51

Closed
soredake opened this issue Feb 23, 2023 · 6 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@soredake
Copy link

It would be nice if syncplay-android can remember selected subtitle index so i wouldn't have to select it again when next file will be played.

@yuroyami
Copy link
Owner

this one used to be an actual feature in previous versions, i forgot to include it again after all the revamping. i will take that into account, thanks for the reminder

@yuroyami yuroyami self-assigned this Feb 24, 2023
@yuroyami yuroyami added the enhancement New feature or request label Feb 24, 2023
@yuroyami
Copy link
Owner

yuroyami commented Jan 6, 2024

@soredake I am not sure if this is working again in v0.13.0. Could you test it for me with both mpv and exo? I'll try to test it myself as well

@soredake
Copy link
Author

soredake commented Jan 6, 2024

@yuroyami I can't test this since shared playlist settings is broken for me #87

@yuroyami
Copy link
Owner

yuroyami commented Jan 7, 2024

@soredake It should also work when you're loading one similar file after another (since that's what happened during shared playlist index change)

@soredake
Copy link
Author

soredake commented Jan 8, 2024

Now subtitle index is remembered, it's been hard to test this since there are so many crashes in this version.

@soredake soredake closed this as completed Jan 8, 2024
@yuroyami
Copy link
Owner

yuroyami commented Jan 8, 2024

@soredake Do kindly report any crashes you're experiencing, I am currently using this version and it's crashing less often for me than the previous one. There are some departments that still require a lot of work to do such as the quick launch shortcuts and shared playlists

EDIT: It's worth noting that with each release, a newer version may contain incompatibilities with its previous version, so in this case it's not possible to install 0.13.0 over the 0.12.0 for example. A clean install is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants