Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Ship noVNC's client side with our package #3

Open
yuvipanda opened this issue Oct 29, 2019 · 5 comments
Open

Ship noVNC's client side with our package #3

yuvipanda opened this issue Oct 29, 2019 · 5 comments
Milestone

Comments

@yuvipanda
Copy link
Owner

In our postBuild, we download noVNC just to use the client side. We then use sed to make some changes.

Instead we should figure out... something else :D Options are:

  1. Vendor just the files we need from novnc
  2. Use the novnc js client to build our own minimal UI

I think 2 is the solution we should go for

@manics
Copy link
Collaborator

manics commented Nov 6, 2019

FYI I chose vnc_lite.html over vnc.html because the latter seems to be a full application rather than just a basic viewer. vnc.html uses LocalStorage to save your current settings including the backend websocket path. This is a big problem running on mybinder since the storage is associated with the domain whereas each desktop is completely independent, and you end up with noVNC attempting to connect to an old non-existent binder.

This was incredibly hard to debug, so thought I'd mention it in case you weren't aware!

@yuvipanda yuvipanda added this to the v1.0 milestone Nov 19, 2019
@djangoliv
Copy link

@manics: I however tried to use vnc.html with jupyterhub but I can't get it to work. Connection always fails. Do you have any idea of the necessary changes?

@manics
Copy link
Collaborator

manics commented Jan 21, 2021

I can't remember whether I ever got it working.

@djangoliv
Copy link

ok thanks.

@djangoliv
Copy link

ok thanks, I will keep on searching.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants