Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist user sessions across process restart #2

Open
yuvipanda opened this issue Mar 30, 2021 · 0 comments
Open

Persist user sessions across process restart #2

yuvipanda opened this issue Mar 30, 2021 · 0 comments

Comments

@yuvipanda
Copy link
Owner

When the service process (and hub) restarts, the currently logged-in user is 'forgotten' and asked to log in again. We should find a way to persist that.
yuvipanda added a commit to yuvipanda/jupyterhub that referenced this issue Apr 8, 2021
@yuvipanda
Don't delete all oauth clients on startup
054c7f2 
When an oauth client changes, we delete all the tokens
associated with that client. This invalidates all user sessions
for that oauth client, and the oauth client's users will need to
go through the OAuth workflow again after the cache period (specified
by cache_max_age in HubAuth, 5min by default). This is fine in theory,
since oauth client information doesn't change frequently.

However, we were deleting and re-adding all oauth clients each time
the hub started! This was unnecessary, since the data was going to
be the same 99% of the time. Rest of the time, we should just update,
preventing unnecessary churn.

This PR does that.

Ref yuvipanda/jupyterhub-configurator#2
Ref berkeley-dsep-infra/datahub#2284
@yuvipanda yuvipanda mentioned this issue Apr 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yuvipanda