Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for init containers and extra volumes/mounts for ssh #75

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Implement support for init containers and extra volumes/mounts for ssh #75

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e5ebd39
ssh: implement support for init containers and extra volumes/mounts
sgaist Oct 4, 2022
a0c2c56
pre-commit: update hooks versions
sgaist Oct 4, 2022
1fb3285
templates: fix indentation
sgaist Oct 4, 2022
9f48100
helm: add init containers and volumes related fields to schema
sgaist Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions helm-chart/jupyterhub-ssh/templates/ssh/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,14 @@ spec:
- name: config
secret:
secretName: {{ include "jupyterhub-ssh.fullname" . }}
{{- with .Values.ssh.extraVolumes }}
{{- . | toYaml | nindent 8 }}
{{- end }}
sgaist marked this conversation as resolved.
Show resolved Hide resolved

{{- with .Values.ssh.initContainers }}
initContainers:
{{- . | toYaml | nindent 8 }}
{{- end }}
containers:
- name: server
image: "{{ .Values.ssh.image.repository }}:{{ .Values.ssh.image.tag | default .Chart.AppVersion }}"
Expand All @@ -40,6 +48,9 @@ spec:
- name: config
mountPath: /etc/jupyterhub-ssh/config
readOnly: true
{{- with .Values.ssh.extraVolumeMounts }}
{{- . | toYaml | nindent 12 }}
{{- end }}
sgaist marked this conversation as resolved.
Show resolved Hide resolved
ports:
- name: ssh
containerPort: 8022
Expand Down
4 changes: 4 additions & 0 deletions helm-chart/jupyterhub-ssh/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@ ssh:
affinity: {}
networkPolicy: {}

initContainers: []
extraVolumes: []
extraVolumeMounts: []

sftp:
enabled: true
replicaCount: 1
Expand Down