Run blockbeat PRs as a whole
#16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull reviewers statsStats of the last 30 days for lnd:
|
yyforyongyu
force-pushed
the
shuffle-tests
branch
from
50e5738 to
bb261f9
Compare
Pull Request Test Coverage Report for Build 11506222681Details
💛 - Coveralls |
yyforyongyu
force-pushed
the
shuffle-tests
branch
27 times, most recently
from
28c2fe6 to
bf47085
Compare
So we won't forget to assert the topology after opening a chain of channels.
This is no longer needed since we don't have standby nodes, plus it's causing panic in windows build due to `edge.Policy` being nil.
There's no need to mine 80ish blocks here.
So the test can run faster.
Also removed the duplicate test cases.
To make the CI indicative, we now starting tracking the flaky tests found when running on Windows. As a starting point, rather than ignore the windows CI entirely, we now identify there are cases where lnd can be buggy when running in windows. We should fix the tests in the future, otherwise the windows build should be deleted.
x - delete - print blocks x x pri
yyforyongyu
force-pushed
the
shuffle-tests
branch
from
d647d48 to
1199fd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.