Skip to content

Commit f3adf45

Browse files
committed
Merge branch 'fr/rebase-i-continue-preserve-options'
"git rebase -i" started with merge strategy options did not propagate them upon "git rebase --continue". * fr/rebase-i-continue-preserve-options: rebase -i: remember merge options beyond continue actions
2 parents 787407e + 040fd39 commit f3adf45

File tree

2 files changed

+23
-11
lines changed

2 files changed

+23
-11
lines changed

git-rebase--interactive.sh

+7-11
Original file line numberDiff line numberDiff line change
@@ -81,17 +81,13 @@ rewritten_pending="$state_dir"/rewritten-pending
8181
# and leaves CR at the end instead.
8282
cr=$(printf "\015")
8383

84-
strategy_args=
85-
if test -n "$do_merge"
86-
then
87-
strategy_args=${strategy:+--strategy=$strategy}
88-
eval '
89-
for strategy_opt in '"$strategy_opts"'
90-
do
91-
strategy_args="$strategy_args -X$(git rev-parse --sq-quote "${strategy_opt#--}")"
92-
done
93-
'
94-
fi
84+
strategy_args=${strategy:+--strategy=$strategy}
85+
eval '
86+
for strategy_opt in '"$strategy_opts"'
87+
do
88+
strategy_args="$strategy_args -X$(git rev-parse --sq-quote "${strategy_opt#--}")"
89+
done
90+
'
9591

9692
GIT_CHERRY_PICK_HELP="$resolvemsg"
9793
export GIT_CHERRY_PICK_HELP

t/t3404-rebase-interactive.sh

+16
Original file line numberDiff line numberDiff line change
@@ -1006,6 +1006,22 @@ test_expect_success 'rebase -i with --strategy and -X' '
10061006
test $(cat file1) = Z
10071007
'
10081008

1009+
test_expect_success 'interrupted rebase -i with --strategy and -X' '
1010+
git checkout -b conflict-merge-use-theirs-interrupted conflict-branch &&
1011+
git reset --hard HEAD^ &&
1012+
>breakpoint &&
1013+
git add breakpoint &&
1014+
git commit -m "breakpoint for interactive mode" &&
1015+
echo five >conflict &&
1016+
echo Z >file1 &&
1017+
git commit -a -m "one file conflict" &&
1018+
set_fake_editor &&
1019+
FAKE_LINES="edit 1 2" git rebase -i --strategy=recursive -Xours conflict-branch &&
1020+
git rebase --continue &&
1021+
test $(git show conflict-branch:conflict) = $(cat conflict) &&
1022+
test $(cat file1) = Z
1023+
'
1024+
10091025
test_expect_success 'rebase -i error on commits with \ in message' '
10101026
current_head=$(git rev-parse HEAD) &&
10111027
test_when_finished "git rebase --abort; git reset --hard $current_head; rm -f error" &&

0 commit comments

Comments
 (0)