From a51b0e1eed94b7349f1fdc916302bcfd31adc813 Mon Sep 17 00:00:00 2001 From: Zach Ahn Date: Sat, 10 Aug 2024 11:48:40 -0400 Subject: [PATCH] Improve tests to quiet new warnings --- test/models/disqualified/record_test.rb | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/test/models/disqualified/record_test.rb b/test/models/disqualified/record_test.rb index f8a47d2..f2d9c74 100644 --- a/test/models/disqualified/record_test.rb +++ b/test/models/disqualified/record_test.rb @@ -32,9 +32,15 @@ def perform test ".claim_one! claims requeued jobs" do NoArgJob.perform_async - claimed_record = Disqualified::Record.claim_one! - claimed_record.unqueue - Disqualified::Record.claim_one! + assert_difference("Disqualified::Record.first.attempts", 2) do + assert_difference("Disqualified::Record.first.attempts", 1) do + claimed_record = Disqualified::Record.claim_one! + claimed_record.unqueue + end + assert_difference("Disqualified::Record.first.attempts", 1) do + Disqualified::Record.claim_one! + end + end end test "#run doesn't run ran jobs" do @@ -49,7 +55,11 @@ def perform test "#run runs jobs" do NoArgJob.perform_async record = Disqualified::Record.runnable.first - record.run! + assert_difference("record.reload.attempts", 1) do + assert_changes("record.reload.finished_at") do + record.run! + end + end end test "#instantiate_handler_and_perform_with_args" do