"E684: list index out of range: 0" when <C-c> in fzf

[zenazn]

If you <C-]> / <Plug>(fzf_tags) on a tag with multiple options, then <C-c> without selecting an option in FZF, vim will barf with the following error message:

Error detected while processing function fzf_tags#FindCommand[1]..fzf_tags#Find[12]..fzf#run[69]..<SNR>24_callback:
line   21:
Vim(let):E684: list index out of range: 0
Error detected while processing function fzf_tags#FindCommand[1]..fzf_tags#Find:
line   12:
E171: Missing :endif

I instead expect FZF / fzf-tags to exit without an error and without jumping me anywhere.

I'm pretty bad at vimscript, but adding the following to the top of s:sink seems to fix the problem:

  if len(a:selection) == 0
    return
  end

[zackhsi]

My specific installation (tmux + nvim + macOS) doesn't actually call s:sink if I <C-c> from the match list.

But without digging too deeply, there's enough branching in fzf#run to make me believe there can be cases where s:sink is called.

If your proposed diff fixes it for you, +1 happy to merge.

[zenazn]

I've been running that diff for a month or so now and it seems to fix things for me 🤷