Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cram/async/io/writer: Add alignment record writer #293

Closed
zaeleus opened this issue Aug 26, 2024 · 0 comments
Closed

cram/async/io/writer: Add alignment record writer #293

zaeleus opened this issue Aug 26, 2024 · 0 comments
Assignees
Labels
cram enhancement New feature or request

Comments

@zaeleus
Copy link
Owner

zaeleus commented Aug 26, 2024

Currently, I cannot compile the async Writer due to

error[E0308]: mismatched types
   --> noodles-util/src/alignment/async/io/writer.rs:80:63
    |
80  |             Self::Cram(writer) => writer.write_record(header, record).await,
    |                                          ------------         ^^^^^^ expected `Record`, found `&dyn Record`
    |                                          |
    |                                          arguments to this method are incorrect
    |
    = note: expected struct `noodles_cram::Record`
            found reference `&dyn noodles_sam::alignment::Record`
note: method defined here
   --> /Users/michael/Projects/noodles/noodles-cram/src/async/io/writer.rs:181:18
    |
181 |     pub async fn write_record(
    |                  ^^^^^^^^^^^^

Which is coming from the fact that cram::async::io::Writer::write_record takes a cram::Record type rather than a &dyn > sam::alignment::Record trait.

mut record: Record,

Originally posted by @mbhall88 in #292 (comment)


The async CRAM writer is missing the equivalent of cram::io::Writer::write_alignment_record.

@zaeleus zaeleus added enhancement New feature or request cram labels Aug 26, 2024
@zaeleus zaeleus self-assigned this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cram enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant