Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for stringData #37

Open
joedborg opened this issue Apr 27, 2022 · 2 comments
Open

No support for stringData #37

joedborg opened this issue Apr 27, 2022 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@joedborg
Copy link

Secrets support stringData, meaning you don't have to Base64 everything, but ClusterSecret doesn't seem to.

@zakkg3
Copy link
Owner

zakkg3 commented May 13, 2022

Missing the stringData instead of Data..
we will need a PR to fix this ;)
https://kubernetes.io/docs/concepts/configuration/secret/#restriction-names-data

@zakkg3 zakkg3 added enhancement New feature or request help wanted Extra attention is needed labels May 19, 2023
@patrungel
Copy link
Contributor

stringData does not replace but comes alongside data; if both sources define the same key, the value from stringData wins.
Here is a draft change:
https://github.com/zakkg3/ClusterSecret/compare/master...patrungel:stringdata?expand=1

it introduces a new field to the CRD, hence the question: is there a plan for how ClusterSecret custom resource will evolve?
As an alternative to just adding .stringData I could suggest moving .data to .target.data and evolving this part further (by adding stringData and then eventually immutability, metadata and what not).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants