Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submission to Nakadi does not work without @EnableScheduling #92

Closed
goekhanak opened this issue Aug 7, 2018 · 1 comment
Closed

Submission to Nakadi does not work without @EnableScheduling #92

goekhanak opened this issue Aug 7, 2018 · 1 comment
Labels
auto-configuration everything about the auto-configuration features bug nakadi-submission spring-boot-2 Issues/PRs which only apply to the Spring-Boot 2 versions (Releases 20.*+)

Comments

@goekhanak
Copy link

goekhanak commented Aug 7, 2018 •
edited by ePaul
Loading

The persisted events are not sent without adding @EnableScheduling to the main class.
Either this should be part of documentation or @EnableNakadiProducer should contain it.
@ePaul ePaul changed the title Does not work without @EnableScheduling Submission to Nakadi does not work without @EnableScheduling Aug 7, 2018
@ePaul ePaul added the spring-boot-2 Issues/PRs which only apply to the Spring-Boot 2 versions (Releases 20.*+) label Aug 7, 2018
@ePaul
Copy link
Member

ePaul commented Aug 7, 2018 •
edited
Loading

Interestingly, this seems to not have been needed in some service where we were using the 4.1.3 version of the library. So maybe that is some difference introduced by the SpringBoot 2 support (in #87 / #89).

@ePaul ePaul added the bug label Aug 7, 2018
BGehrels added a commit that referenced this issue Aug 10, 2018
@BGehrels
Fix #92 - Submission to Nakadi does not work without @EnableScheduling
c271e58
@BGehrels BGehrels mentioned this issue Aug 10, 2018
Merged
BGehrels added a commit that referenced this issue Aug 10, 2018
@BGehrels
Fix #92 - Submission to Nakadi does not work without @EnableScheduling
38dcb7e
@ePaul ePaul added the auto-configuration everything about the auto-configuration features label Aug 10, 2018
BGehrels added a commit that referenced this issue Aug 10, 2018
@BGehrels
Merge pull request #96 from zalando-nakadi/enableScheduling
07b8681 
Fix #92 - Submission to Nakadi does not work without @EnableScheduling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-configuration everything about the auto-configuration features bug nakadi-submission spring-boot-2 Issues/PRs which only apply to the Spring-Boot 2 versions (Releases 20.*+)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ePaul @goekhanak