return in finally can swallow exceptions

[iritkatriel]

In

opentracing-utils/opentracing_utils/libs/_flask.py

Line 145 in 0a4a288

return response

there is a return statement in a finally block, which would swallow any in-flight exception.

This means that if any exception (including a BaseException such as KeyboardInterrupt) is raised from the try body, it will not propagate on as expected.

See also https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions.