Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CompletableFuture with Promise #675

Closed
1 of 7 tasks
whiskeysierra opened this issue May 29, 2019 · 1 comment
Closed
1 of 7 tasks

Replace CompletableFuture with Promise #675

whiskeysierra opened this issue May 29, 2019 · 1 comment

Comments

@whiskeysierra
Copy link
Collaborator

whiskeysierra commented May 29, 2019

Detailed Description

https://github.com/vsilaev/tascalate-concurrent

Context

  • Supports proper cancellation of tasks (incl. parent tasks)
  • Supports interrupts
  • Supports timeouts out of the box, making riptide-timeout obsolete
  • Better support for composing futures

Possible Implementation

Your Environment

  • Version used: 3.0.0-RC.0
@whiskeysierra whiskeysierra added this to the 3.0.0 milestone May 29, 2019
@whiskeysierra whiskeysierra pinned this issue May 29, 2019
@whiskeysierra whiskeysierra modified the milestones: 3.0.0, 4.0.0 Aug 7, 2019
@whiskeysierra
Copy link
Collaborator Author

Interrupts will become obsolete with #328. Timeouts are now already supported using Failsafe and no longer require a dedicated plugin/module. That leaves cancellations which are hopefully dealt with in #326. The remaining composition of futures/promises can already be done by wrapping/decorating/converting futures to promises within client code.

I'm closing this for now until new compelling reasons emerge.

@whiskeysierra whiskeysierra unpinned this issue Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant