diff --git a/script/actions_utils/generate_test_matrix.py b/script/actions_utils/generate_test_matrix.py index a04b9a5d2..2c3c55d65 100644 --- a/script/actions_utils/generate_test_matrix.py +++ b/script/actions_utils/generate_test_matrix.py @@ -32,8 +32,6 @@ class OS(enum.Enum): MACOS = "macos" -# Add mac silicon -# FIXME: https://github.com/zama-ai/concrete-ml-internal/issues/4010 OS_VERSIONS = { OS.LINUX: "ubuntu-20.04", OS.MACOS: ["macos-13", "macos-14"], diff --git a/tests/common/test_serialization.py b/tests/common/test_serialization.py index 5d5ad4da9..c568e16ab 100644 --- a/tests/common/test_serialization.py +++ b/tests/common/test_serialization.py @@ -116,10 +116,9 @@ def test_serialize_random_state(random_state, random_state_type): def test_serialize_sklearn_model(concrete_model_class, load_data): """Test serialization of sklearn_model objects.""" - # FIXME: https://github.com/zama-ai/concrete-ml-internal/issues/4694 # Skip test for regressors that use internal scikit-learn loss classes problematic_models = {"TweedieRegressor", "GammaRegressor", "PoissonRegressor"} - if concrete_model_class.__name__ in problematic_models: + if concrete_model_class.__name__ in problematic_models and "1.1." in sklearn.__version__: pytest.skip( f"Skipping {concrete_model_class.__name__} due to internal scikit-learn " "class serialization issues"