Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support resnet #738

Merged
merged 9 commits into from
Jun 26, 2024
Merged

feat: support resnet #738

merged 9 commits into from
Jun 26, 2024

Conversation

jfrery
Copy link
Collaborator

@jfrery jfrery commented Jun 20, 2024 •
edited
Loading

@jfrery jfrery requested a review from a team as a code owner June 20, 2024 10:21
@cla-bot cla-bot bot added the cla-signed label Jun 20, 2024
andrei-stoian-zama
andrei-stoian-zama reviewed Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@andrei-stoian-zama andrei-stoian-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but:

  • if we can't get the GPU time, maybe remove the GPU line
  • add somewhere that rounding_threshold_bits for the configurations, next to the the n_bits dictionaries

@fd0r
Copy link
Collaborator

fd0r commented Jun 21, 2024

CI failed too

@jfrery jfrery force-pushed the feat/support_resnet branch from fa0b73a to cc589bb Compare June 24, 2024 11:26
@jfrery jfrery force-pushed the feat/support_resnet branch from 5eb7328 to 65ec6ca Compare June 24, 2024 14:42
andrei-stoian-zama
andrei-stoian-zama approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@andrei-stoian-zama andrei-stoian-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, it even has the GPU results

@jfrery jfrery merged commit 6d8a205 into main Jun 26, 2024
15 checks passed
@jfrery jfrery deleted the feat/support_resnet branch June 26, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrei-stoian-zama andrei-stoian-zama andrei-stoian-zama approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jfrery @fd0r @andrei-stoian-zama