From 18081892ab46cba1468c5b228a24440c42ccef33 Mon Sep 17 00:00:00 2001 From: youben11 Date: Tue, 26 Nov 2024 11:32:08 +0100 Subject: [PATCH 1/2] fix(ci): always run notif job --- .github/workflows/concrete_compiler_test_macos_cpu.yml | 1 + .github/workflows/concrete_python_release_cpu.yml | 1 + .github/workflows/concrete_python_test_macos.yml | 1 + 3 files changed, 3 insertions(+) diff --git a/.github/workflows/concrete_compiler_test_macos_cpu.yml b/.github/workflows/concrete_compiler_test_macos_cpu.yml index f305db672d..30d9de1f4b 100644 --- a/.github/workflows/concrete_compiler_test_macos_cpu.yml +++ b/.github/workflows/concrete_compiler_test_macos_cpu.yml @@ -96,6 +96,7 @@ jobs: slack-notif-macos: needs: ["build-and-test"] runs-on: "ubuntu-latest" + if: always() steps: - name: Slack Notification # we want to check that prepare_slack_notif was run diff --git a/.github/workflows/concrete_python_release_cpu.yml b/.github/workflows/concrete_python_release_cpu.yml index 3f775b0faa..108064de26 100644 --- a/.github/workflows/concrete_python_release_cpu.yml +++ b/.github/workflows/concrete_python_release_cpu.yml @@ -450,6 +450,7 @@ jobs: slack-notif-macos: needs: ["test-macos"] runs-on: "ubuntu-latest" + if: always() steps: - name: Slack Notification # we want to check that prepare_slack_notif was run diff --git a/.github/workflows/concrete_python_test_macos.yml b/.github/workflows/concrete_python_test_macos.yml index 805a32fa66..9ae310f518 100644 --- a/.github/workflows/concrete_python_test_macos.yml +++ b/.github/workflows/concrete_python_test_macos.yml @@ -122,6 +122,7 @@ jobs: slack-notif-macos: needs: ["concrete-python-test-pytest"] runs-on: "ubuntu-latest" + if: always() steps: - name: Slack Notification # we want to check that prepare_slack_notif was run From ff6fa72645f6aa110f0fbc0c48b554a1b6d80643 Mon Sep 17 00:00:00 2001 From: Ayoub Benaissa Date: Wed, 27 Nov 2024 10:03:55 +0100 Subject: [PATCH 2/2] fix(ci): run concrete_python_test_macos on change --- .github/workflows/concrete_python_test_macos.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/concrete_python_test_macos.yml b/.github/workflows/concrete_python_test_macos.yml index 9ae310f518..d3bc0ee462 100644 --- a/.github/workflows/concrete_python_test_macos.yml +++ b/.github/workflows/concrete_python_test_macos.yml @@ -3,7 +3,7 @@ on: workflow_dispatch: pull_request: paths: - - .github/workflows/concrete_python_tests_macos.yml + - .github/workflows/concrete_python_test_macos.yml push: branches: - 'main'