From 984c793ffa2412bd441d6c6f60fd03e5b7feddfd Mon Sep 17 00:00:00 2001 From: Benoit Chevallier-Mames Date: Thu, 25 Jul 2024 12:37:32 +0200 Subject: [PATCH] fix(frontend): fixing an issue in the string generation closes #819 --- .../levenshtein_distance.md | 51 +++++++++---------- .../levenshtein_distance.py | 6 ++- 2 files changed, 29 insertions(+), 28 deletions(-) diff --git a/frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.md b/frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.md index 77201f32f0..b7a686e833 100644 --- a/frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.md +++ b/frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.md @@ -131,33 +131,31 @@ Successful end - `python levenshtein_distance.py --autoperf`: Benchmark with random strings, for the different alphabets. ``` - Typical performances for alphabet ACTG, with string of maximal length: - Computing Levenshtein between strings 'CGGA' and 'GCTA' - OK in 4.77 seconds - Computing Levenshtein between strings 'TTCC' and 'CAAG' - OK in 4.45 seconds - Computing Levenshtein between strings 'TGAG' and 'CATC' - OK in 4.38 seconds + Computing Levenshtein between strings 'GCGA' and 'GTCA' - OK in 6.04 seconds + Computing Levenshtein between strings 'TCGA' and 'ACAA' - OK in 5.57 seconds + Computing Levenshtein between strings 'CAGT' and 'CGTT' - OK in 5.63 seconds Typical performances for alphabet string, with string of maximal length: - Computing Levenshtein between strings 'tsyl' and 'slTz' - OK in 13.76 seconds - Computing Levenshtein between strings 'rdfu' and 'qbam' - OK in 12.89 seconds - Computing Levenshtein between strings 'ngoz' and 'fxGw' - OK in 12.88 seconds + Computing Levenshtein between strings 'ctow' and 'qtor' - OK in 17.54 seconds + Computing Levenshtein between strings 'vwky' and 'enfh' - OK in 16.46 seconds + Computing Levenshtein between strings 'dqse' and 'spps' - OK in 16.49 seconds Typical performances for alphabet STRING, with string of maximal length: - Computing Levenshtein between strings 'OjgB' and 'snQc' - OK in 23.94 seconds - Computing Levenshtein between strings 'UXWO' and 'rVgF' - OK in 23.69 seconds - Computing Levenshtein between strings 'NsBT' and 'IFuC' - OK in 23.40 seconds + Computing Levenshtein between strings 'TQBW' and 'LKIZ' - OK in 16.62 seconds + Computing Levenshtein between strings 'HANA' and 'CFVO' - OK in 16.32 seconds + Computing Levenshtein between strings 'BEXY' and 'YAWM' - OK in 16.58 seconds Typical performances for alphabet StRiNg, with string of maximal length: - Computing Levenshtein between strings 'ImNJ' and 'zyUB' - OK in 23.71 seconds - Computing Levenshtein between strings 'upAT' and 'XfWs' - OK in 23.52 seconds - Computing Levenshtein between strings 'HVXJ' and 'dQvr' - OK in 23.73 seconds + Computing Levenshtein between strings 'iYmH' and 'ONnz' - OK in 30.56 seconds + Computing Levenshtein between strings 'hZyX' and 'vhHH' - OK in 30.11 seconds + Computing Levenshtein between strings 'sJdj' and 'strn' - OK in 30.48 seconds Successful end - ``` ## Complexity analysis @@ -181,30 +179,29 @@ it's only signed 3-bit PBS. The benchmarks were done using Concrete 2.7 on `hpc7a` machine on AWS, and give: ``` - Typical performances for alphabet ACTG, with string of maximal length: - Computing Levenshtein between strings 'CGGA' and 'GCTA' - OK in 4.77 seconds - Computing Levenshtein between strings 'TTCC' and 'CAAG' - OK in 4.45 seconds - Computing Levenshtein between strings 'TGAG' and 'CATC' - OK in 4.38 seconds + Computing Levenshtein between strings 'AGTC' and 'TGGA' - OK in 6.00 seconds + Computing Levenshtein between strings 'GTAA' and 'AGAC' - OK in 5.51 seconds + Computing Levenshtein between strings 'TCTT' and 'CACG' - OK in 5.49 seconds Typical performances for alphabet string, with string of maximal length: - Computing Levenshtein between strings 'tsyl' and 'slTz' - OK in 13.76 seconds - Computing Levenshtein between strings 'rdfu' and 'qbam' - OK in 12.89 seconds - Computing Levenshtein between strings 'ngoz' and 'fxGw' - OK in 12.88 seconds + Computing Levenshtein between strings 'jqdk' and 'zqlf' - OK in 17.43 seconds + Computing Levenshtein between strings 'uquc' and 'qvvp' - OK in 16.50 seconds + Computing Levenshtein between strings 'vebm' and 'ybqo' - OK in 16.46 seconds Typical performances for alphabet STRING, with string of maximal length: - Computing Levenshtein between strings 'OjgB' and 'snQc' - OK in 23.94 seconds - Computing Levenshtein between strings 'UXWO' and 'rVgF' - OK in 23.69 seconds - Computing Levenshtein between strings 'NsBT' and 'IFuC' - OK in 23.40 seconds + Computing Levenshtein between strings 'UQES' and 'NWXQ' - OK in 16.53 seconds + Computing Levenshtein between strings 'LAJG' and 'NEGP' - OK in 16.26 seconds + Computing Levenshtein between strings 'OSQG' and 'OTEH' - OK in 16.52 seconds Typical performances for alphabet StRiNg, with string of maximal length: - Computing Levenshtein between strings 'ImNJ' and 'zyUB' - OK in 23.71 seconds - Computing Levenshtein between strings 'upAT' and 'XfWs' - OK in 23.52 seconds - Computing Levenshtein between strings 'HVXJ' and 'dQvr' - OK in 23.73 seconds + Computing Levenshtein between strings 'ixgu' and 'cOSy' - OK in 30.94 seconds + Computing Levenshtein between strings 'QGCj' and 'Lknx' - OK in 29.82 seconds + Computing Levenshtein between strings 'fKVC' and 'xqaI' - OK in 30.27 seconds Successful end ``` diff --git a/frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.py b/frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.py index b3e3e8787e..c22942de81 100644 --- a/frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.py +++ b/frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.py @@ -41,6 +41,7 @@ def dna(): def __init__(self, letters: str): self.letters = letters + self.mapping_to_int = {} for i, c in enumerate(self.letters): self.mapping_to_int[c] = i @@ -76,7 +77,10 @@ def random_pick_in_values(self) -> int: def _random_string(self, length: int) -> str: """Pick a random string in the alphabet.""" - return "".join([random.choice(list(self.mapping_to_int)) for _ in range(length)]) + ans = "".join([random.choice(list(self.mapping_to_int)) for _ in range(length)]) + check = [c in self.letters for c in ans] + assert all(check), "Issue in generation" + return ans def prepare_random_patterns(self, len_min: int, len_max: int, nb_strings: int) -> list: """Prepare random patterns of different lengths."""