Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated keyurl description #45

Merged
merged 4 commits into from
Oct 4, 2024
Merged

docs: updated keyurl description #45

merged 4 commits into from
Oct 4, 2024

Conversation

jot2re
Copy link
Contributor

@jot2re jot2re commented Oct 1, 2024

@jot2re jot2re requested a review from leventdem October 1, 2024 11:40
Copy link
Contributor

@leventdem leventdem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, it could be good to have the review of @immortal-tofu also.

@jot2re
Copy link
Contributor Author

jot2re commented Oct 2, 2024

BTW I am unsure what I should do in relation to the markdown failure. It is from a file I did not touch and seems to just be example URLs and hence using localhost

@immortal-tofu
Copy link
Collaborator

Can you add these tags around the broken link?

<! -- markdown-link-check-disable -->

and

<! -- markdown-link-check-enable-->

@jot2re
Copy link
Contributor Author

jot2re commented Oct 4, 2024

@immortal-tofu added in a0c2dab

@immortal-tofu
Copy link
Collaborator

LGTM, I'll change fhevmjs

@jot2re jot2re merged commit ce8cf7f into main Oct 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants