Skip to content
This repository has been archived by the owner on Dec 23, 2024. It is now read-only.

feat: add clean interpreter.Run integration function #39

Closed
wants to merge 1 commit into from

Conversation

youben11
Copy link
Member

@youben11 youben11 commented Dec 6, 2023

After ethereum/go-ethereum#28633, I realized we can have a clean integration function for interpreter.Run, without requiring integrators to modify the inner function with branching, but to only call our own implementation.

This PR however, makes fhevm-go more dependent of geth, which is something we may not want to have, so we may not want to merge it at the end.

@youben11 youben11 requested a review from dartdart26 December 6, 2023 09:02
@youben11
Copy link
Member Author

youben11 commented Dec 7, 2023

Something to consider: I had an import cycle in ethermint because of this

@dartdart26
Copy link
Contributor

@youben11 Do you still want to merge it?

@youben11
Copy link
Member Author

youben11 commented Jan 9, 2024

@youben11 Do you still want to merge it?

I wasn't quite happy with the final result of it as it became much more dependent of geth, and I don't think it's a good idea to merge. Do you have an opinion on this?

@dartdart26
Copy link
Contributor

@youben11 Do you still want to merge it?

I wasn't quite happy with the final result of it as it became much more dependent of geth, and I don't think it's a good idea to merge. Do you have an opinion on this?

Cool, let's close it.

@youben11 youben11 closed this Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants