Skip to content
This repository has been archived by the owner on Dec 23, 2024. It is now read-only.

Feat/kms: call first version of KMS for reencrypt and decrypt #47

Merged
merged 14 commits into from
Jan 8, 2024
Merged

Feat/kms: call first version of KMS for reencrypt and decrypt #47

merged 14 commits into from
Jan 8, 2024

Conversation

leventdem
Copy link
Contributor

Call KMS for two purposes:

  • reencryption request: very early version, proof and related security are in progress
  • decryption request: rationale is to minimize decryption calls and replace them by cmux, but some e2e test still require decryption

tremblaythibaultl and others added 6 commits December 27, 2023 13:53
@tremblaythibaultl @leventdem
feat(): fetch reencryptions from kms
c6e9dd2
@tremblaythibaultl @leventdem
fix(): make e2e test work
b504e2c
@tremblaythibaultl @leventdem
fix(): use new protobuf API version
958b426
@tremblaythibaultl @leventdem
feat(): fetch kms endpoint address from env
70bdc30
@leventdem
chore(tfhe-rs): update to version tfhe-rs-0.4.1
eaf28a1
@leventdem
feature(decrypt): call KMS for decryption
8dd0820 
IMPORTANT: the decrypt call should be replaced in most cases by cmux
It is still called in Governor example in fhevm repository.
To make tests passing we keep it for now.
In the future, it will be replaced by async decryption
For this early first version of KMS this is acceptable.
@leventdem leventdem changed the title Feat/kms Feat/kms: call first version of KMS for reencrypt and decrypt Dec 27, 2023
immortal-tofu and others added 8 commits January 4, 2024 13:47
@leventdem leventdem changed the base branch from main to louis/kms-mvp January 8, 2024 13:38
@leventdem leventdem changed the base branch from louis/kms-mvp to main January 8, 2024 13:40
@leventdem leventdem requested a review from youben11 January 8, 2024 13:41
youben11
youben11 approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@youben11 youben11 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've already reviewed most of the commits from other PRs, so it's a merge for me!

@leventdem leventdem merged commit 952262c into main Jan 8, 2024
2 checks passed
@leventdem leventdem deleted the feat/kms branch January 8, 2024 14:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@youben11 youben11 youben11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@leventdem @youben11 @tremblaythibaultl @immortal-tofu @david-zk