Skip to content
This repository has been archived by the owner on Dec 23, 2024. It is now read-only.

Update to TFHE-rs 0.5.1 #71

Merged
merged 8 commits into from
Feb 1, 2024
Merged

Update to TFHE-rs 0.5.1 #71

merged 8 commits into from
Feb 1, 2024

Conversation

immortal-tofu
Copy link
Contributor

@immortal-tofu immortal-tofu commented Jan 31, 2024 •
edited
Loading

  • Boolean function returns FheBool. To simplify migration, FheBool are converted to FheUint8
  • git submodule to specific commint which introduces a fix in the Makefile. Need to be changed to a tag later
  • Remove gas estimation test since we'll use directly tfhe-rs benchmarks for the next release

youben11
youben11 reviewed Feb 1, 2024
View reviewed changes
fhevm/tfhe.go Show resolved Hide resolved
IceTDrinker
IceTDrinker reviewed Feb 1, 2024
View reviewed changes
fhevm/tfhe.go Outdated Show resolved Hide resolved
youben11
youben11 suggested changes Feb 1, 2024
View reviewed changes
Copy link
Member

@youben11 youben11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change and we will be good to go I think

fhevm/tfhe.go Outdated Show resolved Hide resolved
fhevm/tfhe.go Outdated Show resolved Hide resolved
@immortal-tofu immortal-tofu merged commit ce9f228 into main Feb 1, 2024
1 check passed
@immortal-tofu immortal-tofu deleted the tfhe-rs-0.5.0 branch February 1, 2024 16:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IceTDrinker IceTDrinker IceTDrinker left review comments

@youben11 youben11 youben11 approved these changes

@dartdart26 dartdart26 Awaiting requested review from dartdart26

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@immortal-tofu @youben11 @IceTDrinker