Fix bytesToNumber()
#42
Conversation
This fixes `bytesToNumber()` to always return the result as an unsigned integer. Example: `byteArray` holds the value `2^32 - 3`, which is `11111111111111111111111111111101` in binary. The old implementation uses the `number` type, which is a signed integer, to calculate intermediate values. And because the most significant bit (MSB) is turned on, it interprets this as a negative number and returns `-3`.
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @assafmo on file. In order for us to review and merge your code, please sign:
If you already signed one of this document, just wait to be added to the bot config. |
|
Thank you! Buffer is not available in browser but I think we use polyfill. Did you test it in browser? I'll checkout the branch and test. |
|
No, I've only tested it on nodejs. |
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @assafmo on file. In order for us to review and merge your code, please sign:
If you already signed one of this document, just wait to be added to the bot config. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
This fixes
bytesToNumber()to always return the result as an unsigned integer.Example:
byteArrayholds the value2^32 - 3, which is11111111111111111111111111111101in binary. The old implementation uses thenumbertype, which is a signed integer, to calculate intermediate values. And because the most significant bit (MSB) is turned on, it interprets this as a negative number and returns-3.