Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dt/fix/slab failure msg #28

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Dt/fix/slab failure msg #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
883e38f
chore(slab): fix task status handling
soonum Jul 5, 2024
1ae2fa0
chore(gh): set runner wait timeout to 30 mins
soonum Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/gh.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ async function getRunner(label) {
}

async function waitForRunnerRegistered(label) {
const timeoutSeconds = 900
const timeoutSeconds = 1800
IceTDrinker marked this conversation as resolved.
Show resolved Hide resolved
const retryIntervalSeconds = 10
const quietPeriodSeconds = 30
let waitSeconds = 0
Expand Down
11 changes: 7 additions & 4 deletions src/slab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,18 @@ async function waitForInstance(taskId, taskName) {

if (response.ok) {
const body = await response.json()
if (body[taskName].status.toLowerCase() === 'done') {
const task_status = body[taskName].status.toLowerCase()

if (task_status === 'done') {
await removeTask(taskId)
return body
} else if (body[taskName].status.toLowerCase() === 'failed') {
await removeTask(taskId)
} else if (task_status === 'failed') {
core.error(
`Instance task failed (details: ${body[taskName].status.details})`
`Instance task failed (details: ${body[taskName].details})`
)
core.setFailed('Failure occurred while waiting for instance.')
await removeTask(taskId)
return
}
} else {
core.error(
Expand Down
Loading