Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): action/upload-artifacts deprecation of all versions before v4 #89

Closed
wants to merge 2 commits into from
Closed

chore(deps): action/upload-artifacts deprecation of all versions before v4 #89

wants to merge 2 commits into from

Conversation

DerekRoberts
Copy link
Contributor

Update action/upload-artifacts to v4 to address deprecations. Also bumped patch versions for GitHub's actions/core, because why not?

Showing up as an annotation is workflows. E.g.:

Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "zap_backend", "zap_frontend".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

dependabot bot and others added 2 commits April 23, 2024 23:54
* Bump undici from 5.28.3 to 5.28.4

Bumps [undici](https://github.com/nodejs/undici) from 5.28.3 to 5.28.4.
- [Release notes](https://github.com/nodejs/undici/releases)
- [Commits](nodejs/undici@v5.28.3...v5.28.4)

---
updated-dependencies:
- dependency-name: undici
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update dist file and changelog

Update dist file with latest changes.
Add changelog entry.

Signed-off-by: thc202 <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: thc202 <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: thc202 <[email protected]>
@thc202
Copy link
Member

thc202 commented Apr 24, 2024

This is not updating the required dependency moreover we are not updating it on purpose, it's not yet supported on GHES: github/roadmap#930

@thc202 thc202 closed this Apr 24, 2024
@DerekRoberts
Copy link
Contributor Author

@thc202 The required dependency? I'm receiving some pretty explicit deprecation messaging around actions/upload-artifact <4.

For GHES, would you like this reopened when their issue is resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants