Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Key binds screen #108

Merged
merged 72 commits into from
May 18, 2024
Merged

feat: Key binds screen #108

merged 72 commits into from
May 18, 2024

Conversation

gguio
Copy link

@gguio gguio commented Apr 22, 2024

  • test custom binds works
  • remove querySelector in favor of React style props, simplify
  • in custom keybindings: extract root element from .map into component (eg CustomCommandContainer)
  • remove dangerous html
  • align ui for custom binds: binds on bottom, actions are grouped (so it feels like binds and custom inputs are in the same container)
  • test all works on resolutions (1008x862)
  • note text
  • fix crashes

Copy link

codesandbox bot commented Apr 22, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@zardoy
Copy link
Owner

zardoy commented Apr 24, 2024

/deploy

1 similar comment
@zardoy
Copy link
Owner

zardoy commented Apr 24, 2024

/deploy

Copy link

Deployed to Vercel Preview: https://prismarine-4cp9ba7ny-zaro.vercel.app
Playground
Storybook

@zardoy
Copy link
Owner

zardoy commented Apr 24, 2024

/deploy

Copy link

Deployed to Vercel Preview: https://prismarine-m65p859xr-zaro.vercel.app
Playground
Storybook

@zardoy
Copy link
Owner

zardoy commented Apr 27, 2024

/deploy

Copy link

Deployed to Vercel Preview: https://prismarine-cl7vhimyx-zaro.vercel.app
Playground
Storybook

@zardoy
Copy link
Owner

zardoy commented Apr 27, 2024

/deploy

Copy link

Deployed to Vercel Preview: https://prismarine-2p8bd6ngv-zaro.vercel.app
Playground
Storybook

@gguio
Copy link
Author

gguio commented May 14, 2024

/deploy

Copy link

Deployed to Vercel Preview: https://prismarine-1hvzfa5hn-zaro.vercel.app
Playground
Storybook

@gguio
Copy link
Author

gguio commented May 14, 2024

/deploy

Copy link

Deployed to Vercel Preview: https://prismarine-8limgstch-zaro.vercel.app
Playground
Storybook

@zardoy
Copy link
Owner

zardoy commented May 14, 2024

/deploy

Copy link

Deployed to Vercel Preview: https://prismarine-rfw1knwul-zaro.vercel.app
Playground
Storybook

@zardoy
Copy link
Owner

zardoy commented May 15, 2024

/deploy

Copy link

Deployed to Vercel Preview: https://prismarine-1bhreosco-zaro.vercel.app
Playground
Storybook

@gguio
Copy link
Author

gguio commented May 17, 2024

/deploy

Copy link

Deployed to Vercel Preview: https://prismarine-748k2kztw-zaro.vercel.app
Playground
Storybook

@zardoy zardoy changed the title Key binds screen feat: Key binds screen May 18, 2024
@zardoy
Copy link
Owner

zardoy commented May 18, 2024

/deploy

Copy link

Deployed to Vercel Preview: https://prismarine-i4dit77wj-zaro.vercel.app
Playground
Storybook

@zardoy zardoy merged commit 6bf1085 into zardoy:next May 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants