Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add ability for zarf to find oci artifacts for fluxcd ocirepo resource #3238

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

a1994sc
Copy link
Contributor

@a1994sc a1994sc commented Nov 13, 2024

Description

When trying to discover images with the OCIRepositry kind from FluxCD, zarf did not have logic for finding them with zarf dev find-images

Checklist before merging

@a1994sc a1994sc requested review from a team as code owners November 13, 2024 17:53
Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit d9a741e
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/673cf182fd11fe0008df5cfb

@a1994sc
Copy link
Contributor Author

a1994sc commented Nov 20, 2024

Fixes #3255

@phillebaba
Copy link
Member

phillebaba commented Nov 26, 2024

As with #3236 we are currently refactoring findImages so it will be hard to take this PR at this moment. I will be happy to look at this when the refactoring work is completed.

@a1994sc
Copy link
Contributor Author

a1994sc commented Nov 26, 2024

OK, that works for me @phillebaba, thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants