Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add logger to packager.Publish #3259

Merged
merged 2 commits into from
Nov 21, 2024
Merged

feat: add logger to packager.Publish #3259

merged 2 commits into from
Nov 21, 2024

Conversation

mkcp
Copy link
Contributor

@mkcp mkcp commented Nov 21, 2024

Description

This one ended up being really simple because most of the downstream code had already been ported to slog. I started updating the tests to use the new logging, but decided that it's better if we wait until we swap over to the default format. Added a couple review comments for discussion.

Related Issue

Relates to #2576

Checklist before merging

@mkcp mkcp self-assigned this Nov 21, 2024
@mkcp mkcp requested review from a team as code owners November 21, 2024 01:19
Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit daeb177
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/673f5f61cee3240008486266

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/packager/publish.go 0.00% 9 Missing ⚠️
Files with missing lines Coverage Δ
src/pkg/packager/publish.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes


🚨 Try these New Features:

@mkcp mkcp modified the milestones: v0.43.0, v0.44.0 Nov 21, 2024
@mkcp mkcp added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit a7334b8 Nov 21, 2024
26 checks passed
@mkcp mkcp deleted the mkcp/cmd-publish-logger branch November 21, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants