Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add metadata.annotations to package schema #3319

Merged
merged 1 commit into from
Dec 12, 2024
Merged

feat: add metadata.annotations to package schema #3319

merged 1 commit into from
Dec 12, 2024
+22 −2

Conversation

AustinAbro321
Copy link
Contributor

@AustinAbro321 AustinAbro321 commented Dec 11, 2024 •
edited
Loading

Description

Adds metadata annotations

Fixes #2976

Checklist before merging

@AustinAbro321
add annotations
5711dd6 
Signed-off-by: Austin Abro <[email protected]>
@netlify Netlify
Copy link

netlify bot commented Dec 11, 2024 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 5711dd6
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6759fc7a2c5f87000829ca8d

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/zoci/push.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/api/v1alpha1/package.go 73.68% <ø> (ø)
src/internal/packager2/layout/oci.go 22.91% <100.00%> (+0.81%) ⬆️
src/pkg/zoci/push.go 0.00% <0.00%> (ø)

@AustinAbro321 AustinAbro321 marked this pull request as ready for review December 11, 2024 21:12
@AustinAbro321 AustinAbro321 requested review from a team as code owners December 11, 2024 21:12
@AustinAbro321 AustinAbro321 changed the title feat: add metadata annotations feat: add metadata.annotations to Zarf schema Dec 11, 2024
@AustinAbro321 AustinAbro321 changed the title feat: add metadata.annotations to Zarf schema feat: add metadata.annotations to package schema Dec 11, 2024
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 7af3336 Dec 12, 2024
26 checks passed
@AustinAbro321 AustinAbro321 deleted the add-metadata-annotations branch December 12, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schristoff schristoff schristoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add OCI annotations to manifests and indexes
2 participants
@AustinAbro321 @schristoff