Agent and threads #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Necr0x0Der
reviewed
Nov 8, 2024
motto/thread_agents/thread_agents.py
Outdated
| from hyperon.ext import register_atoms | ||
| from hyperon.exts.agents import BaseListeningAgent | ||
|
|
||
| class ListeningAgent(DialogAgent, BaseListeningAgent): |
There was a problem hiding this comment.
I guess we can avoid multiple inheritance here. Isn't DialogAgent a descendant of BaseListeningAgent? If not (or will not after refactoring BaseListeningAgent in hyperon-experimental, it may make sense to consider inheriting the base agent class in metta-motto from it.
Necr0x0Der
reviewed
Nov 20, 2024
motto/thread_agents/thread_agents.py
Outdated
| } | ||
|
|
||
|
|
||
| if __name__ == '__main__': |
There was a problem hiding this comment.
Is it ok to have this code here? It looks like an example rather than a functional code for the agent
Necr0x0Der
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example of listening agent. depends on trueagi-io/hyperon-experimental#793