Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vocabularies #96

Merged
merged 12 commits into from
Dec 9, 2023
Merged

Update vocabularies #96

merged 12 commits into from
Dec 9, 2023

Conversation

tpluscode
Copy link
Contributor

@tpluscode tpluscode commented Oct 16, 2023

  1. Adds SHACL Advanced Features to sh (re feat: terms from SHACL-AF draft rdf-vocabularies#176)
  2. Adds new prefix shsh
  3. Other updated prefixes:
    • cert
    • earl
    • gs1
    • m41
    • oidc
    • pim
    • solid
    • stat

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2023

⚠️ No Changeset found

Latest commit: 1057cb2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ludovicm67
Copy link
Member

Just to have it written somewhere:

The fibers module leads to some issues.
By removing it from the dev dependencies, it's able to build and run again on newer NodeJS versions.
They say that it's not supporting Node 16+ (see: https://github.com/laverdet/node-fibers).

Newest prefixes seem to be missing on the page, even by building everything from scratch.
This requires some investigation to know why newest prefixes are not available.

@ludovicm67
Copy link
Member

The fibers module leads to some issues. By removing it from the dev dependencies, it's able to build and run again on newer NodeJS versions. They say that it's not supporting Node 16+ (see: https://github.com/laverdet/node-fibers).

Done by @tpluscode 👍

So on my side, it's able to build as expected.
I will just upgrade the Node version that is used in the Docker image in a new commit.

Newest prefixes seem to be missing on the page, even by building everything from scratch. This requires some investigation to know why newest prefixes are not available.

After investigation, it seems that the shsh prefix is being filtered out as the prefix that is in @zazuko/vocabularies is using https instead of http.
After this gets fixed, and after we upgrade that dependency here, we can get something which is working.

I don't know if there are any prefix or property which is still missing.
If it's the case, is it possible to get some examples so that I can check?

@ludovicm67
Copy link
Member

I did the work to upgrade the Node version used in the Docker image in this PR: #97.

This will make sure that the upgrades of dependencies will be working as expected once we merge this PR.

@ludovicm67
Copy link
Member

@tpluscode can you trigger a new patch release for @zazuko/prefixes?
This is the last step to have the shsh prefix included.

@tpluscode
Copy link
Contributor Author

Done, v2.1.1

@ludovicm67
Copy link
Member

Done, v2.1.1

Great, thanks!

@ludovicm67 ludovicm67 merged commit ad6f322 into master Dec 9, 2023
3 checks passed
@ludovicm67 ludovicm67 deleted the up-vocabs branch December 9, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants