Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User can zoom in to NaN when scrolling #381

Closed
kudlav opened this issue Jun 22, 2024 · 6 comments · Fixed by #383
Closed

User can zoom in to NaN when scrolling #381

kudlav opened this issue Jun 22, 2024 · 6 comments · Fixed by #383

Comments

@kudlav
Copy link
Contributor

kudlav commented Jun 22, 2024

Zooming in can cause zooming into the terrain when using a map with tilted terrain. Results into broken app and the URL:
https://osmapp.org/#NaN/49.2177/16.6333

It's hard to restore the app.
After refreshing the site, the following error occurs. The app should reset the zoom and position when the position becomes invalid.
obrazek

To fix the website use has to:

  1. change URL to valid (e.g. https://osmapp.org/#10/49.2177/16.6333)
  2. press enter
  3. refresh the page
@kudlav
Copy link
Contributor Author

kudlav commented Jun 22, 2024

Tested with Firefox 127, Chrome 126
GIF 22 06 2024 12-51-13

@zbycz
Copy link
Owner

zbycz commented Jun 22, 2024

Fixed both saving invalid zoom to URL and crashing on invalid view from other causes. Thanks for a great report. 👍

btw, it looks like an issue in maplibre-gl if you wanted to report there

@kudlav
Copy link
Contributor Author

kudlav commented Jun 27, 2024

Existing maplibre-gl-js issue: maplibre/maplibre-gl-js#4235

@zbycz
Copy link
Owner

zbycz commented Aug 14, 2024

maplibre 4.5.2 is also fixing the underlying issue "Fix camera being able to move into 3D terrain"

Updated here #381 & deployed right now.

@kudlav
Copy link
Contributor Author

kudlav commented Aug 14, 2024

Fix of the crash is still in progress:
maplibre/maplibre-gl-js#1542

@zbycz
Copy link
Owner

zbycz commented Aug 15, 2024

I see, thanks - so they probably put wrong issue in the Relase notes 😄 https://github.com/maplibre/maplibre-gl-js/releases/tag/v4.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants