Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show tagged photos #95

Closed
govvin opened this issue Apr 16, 2022 · 4 comments
Closed

Show tagged photos #95

govvin opened this issue Apr 16, 2022 · 4 comments

Comments

@govvin
Copy link

govvin commented Apr 16, 2022

This app looks promising! I noticed that some objects will be associated with photos from Wikipedia.

It would be awesome if you can display other tagged photos (e.g., image=, mapillary=, etc) for an object, too.

@zbycz
Copy link
Owner

zbycz commented Apr 20, 2022

Hi, thanks for the praise :)

As for the image=* tag, it should work for both:

  • an URL pointing directly to an image file (jpg,png etc.)
  • a wikimedia commons image starting with File:

I would be glad to hear if some usecases are missing. Or the best - post here some OsmAPP urls of items where you would expect an image.

As for the mapillary=* tag, i am not sure. I guess it is not so widely in use (taginfo says 200k nodes) and it can be probably replace with image=https://mapillary...?

btw, osmapp was using Mapillary API for showing street photo for each feature, but now i see they have changed API and nothing is shown - new issue here: #97

@govvin
Copy link
Author

govvin commented Apr 20, 2022

From the OSM wiki discussions, I don't think the image=* tag is meant to replace with mapillary=* , and ideally, their values shouldn't be a duplicate of each other.

Good to see that you actually found the cause of the mapillary issue! Thanks!

@govvin govvin closed this as completed Apr 20, 2022
@contrapunctus-1
Copy link

The wikimedia_commons=* key may have a "Category:..." value too, but it seems osmapp only shows a single photo in such cases. (I have only tested on mobile, though...)

e.g. https://osmapp.org/node/11228824231

Please show all photographs found in the linked category, possibly by using a side-scrolling UI similar to Google Maps.

@Dlurak
Copy link
Collaborator

Dlurak commented Sep 14, 2024

Please show all photographs found in the linked category

I'm currently building a ui to show multiple but not all photos. Also see this comment on another issue

#539 is the relevant pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants