Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explicit TLS disable #145

Closed
LarryRuane opened this issue Nov 19, 2019 · 1 comment
Closed

explicit TLS disable #145

LarryRuane opened this issue Nov 19, 2019 · 1 comment
Assignees
@LarryRuane
Labels
ZECWallet Features from Aditya's wallet

Comments

@LarryRuane
Copy link
Collaborator

Aditya's branch includes a change to make the disabling of TLS explicit, rather than inferred by the absence of the -tls-cert and -tls-key command-line arguments to lightwalletd. This provides more security as it prevents the user from unknowingly not using TLS; the user must explicitly specify that TLS will not be used. Not required, but a good safety measure.
@LarryRuane LarryRuane added the ZECWallet Features from Aditya's wallet label Nov 19, 2019
@LarryRuane LarryRuane self-assigned this Nov 19, 2019
@LarryRuane
Copy link
Collaborator Author

Turns out this was already there, in both versions, implemented independently (hackworks had the name -very-insecure, Aditya's repo had the name -no-tls. I'm merging these two as part of addressing review comments for https://app.zenhub.com/workspaces/wallet-5db8aa0244512d0001e0968e/issues/zcash-hackworks/lightwalletd/143 so I will not have a separate PR for this, will be part of #149.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LarryRuane LarryRuane

Labels
ZECWallet Features from Aditya's wallet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lindanlee @LarryRuane