Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetTaddressTxids is misnamed #426

Closed
defuse opened this issue Jan 31, 2023 · 2 comments · Fixed by #427
Closed

GetTaddressTxids is misnamed #426

defuse opened this issue Jan 31, 2023 · 2 comments · Fixed by #427

Comments

@defuse
Copy link
Collaborator

defuse commented Jan 31, 2023

The name GetTaddressTxids suggests that the RPC returns a list of txids, but it actually returns the raw transaction data for all of the transactions.

@LarryRuane
Copy link
Collaborator

It doesn't seem possible to rename this method in a backward-compatible way. I found this article on the subject:

The following items are protocol and binary breaking changes:

  • Renaming a package, service or method

GetTAddressTxids is a method introduced in #149.

We could add a new method with a better name (I'd favor GetTAddressTransactions) that does exactly the same thing, and then remove the old name when we're sure that all gRPC clients have changed to using the new name, but it's hard to know when we've reached that point. So I'd say it probably isn't worth making any changes.

What do you think?

We should at least document that the method is misnamed, I just create #427 to do that.

@LarryRuane
Copy link
Collaborator

Closing for now, let me know if you'd like this addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants