Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finished try-on ui #14

Merged
merged 5 commits into from
Dec 16, 2021
Merged

Finished try-on ui #14

merged 5 commits into from
Dec 16, 2021

Conversation

zrpxx
Copy link
Collaborator

@zrpxx zrpxx commented Dec 15, 2021

No description provided.

@zrpxx zrpxx requested a review from wmn-231314 December 15, 2021 14:47
wmn-231314
wmn-231314 approved these changes Dec 15, 2021
View reviewed changes
Copy link
Collaborator

@wmn-231314 wmn-231314 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

见下一条

wmn-231314
wmn-231314 requested changes Dec 15, 2021
View reviewed changes
Copy link
Collaborator

@wmn-231314 wmn-231314 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zrpxx 重复点击时会出现圆形图片和方形图片随机切换的问题
TODO: 首页进入时的相应跳转
51c161fef2c62a80229d4441fdc5f78

@zrpxx
Copy link
Collaborator Author

zrpxx commented Dec 16, 2021 •
edited
Loading

添加了主界面跳转；
图片圆角问题怀疑是第三方库bug，尝试修复未果。

      override fun onViewAttachedToWindow(viewHolder: ViewHolder) {

            super.onViewAttachedToWindow(viewHolder)

            (viewHolder.mImg as NiceImageView).isCircle(true)

            (viewHolder.mImg as NiceImageView).setCornerRadius(32)

    }

@zrpxx zrpxx requested a review from wmn-231314 December 16, 2021 04:46
@zrpxx
Copy link
Collaborator Author

zrpxx commented Dec 16, 2021

第三方库圆角bug已有相关issue反馈。
shehuan/NiceImageView#27

@zrpxx
Copy link
Collaborator Author

zrpxx commented Dec 16, 2021

根据相关issue修复了圆角问题。
shehuan/NiceImageView#22

wmn-231314
wmn-231314 approved these changes Dec 16, 2021
View reviewed changes
Copy link
Collaborator

@wmn-231314 wmn-231314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

未发现问题

@wmn-231314 wmn-231314 merged commit 00854a8 into master Dec 16, 2021
@zrpxx zrpxx deleted the TryOn branch December 18, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmn-231314 wmn-231314 wmn-231314 approved these changes

Assignees

@zrpxx zrpxx

@wmn-231314 wmn-231314

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zrpxx @wmn-231314