Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPUI wish list #19472

Closed
1 task done
krstp opened this issue Oct 20, 2024 · 4 comments
Closed
1 task done

GPUI wish list #19472

krstp opened this issue Oct 20, 2024 · 4 comments
Labels
bug [core label] gpui GPUI rendering framework support

Comments

@krstp
Copy link

krstp commented Oct 20, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

A few wishes:

  • I am trying to get a grip around GPUI. Venturing into examples/ folder (https://github.com/zed-industries/zed/tree/main/crates/gpui/examples) I tried to check some of the samples. As such animation.py does not seem to cause any animation, just a black hello on green square. What I am reporting here is I suppose a bug of examples code.

  • Additionally trying different examples, this is the message I get:

2024-10-19 19:17:04.236 gpui[35381:2487415] +[IMKClient subclass]: chose IMKClient_Legacy
2024-10-19 19:17:04.236 gpui[35381:2487415] +[IMKInputSession subclass]: chose IMKInputSession_Legacy
2024-10-19 19:17:04.245 gpui[35381:2487415] NSKeyBindingManager: Bad key binding selector for '^@' = 'noop'
  • Would be great if gpui (https://www.gpui.rs/#examples) deserved its own repository. It has its own website, but the only code seems to live as Zed's crate 🤔

  • gif viewer also seems to be missing some creates out of the box and not stated dependency, i.e.

28 |     env_logger::init();
   |     ^^^^^^^^^^ use of undeclared crate or module `env_logger`
  • Overall my wish if if GPUI could be more self contained with workable sample code. Would be great to pick up on it

Environment

MacOS

If applicable, add mockups / screenshots to help explain present your vision of the feature

See text above.

If applicable, attach your Zed.log file to this issue.

Zed.log
@krstp krstp added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Oct 20, 2024
@xb284524239
Copy link

Agreed!
For a long time, the Rust community has lacked a powerful native GUI framework. I hope that GPUI can become the most powerful and general-purpose native GUI framework in Rust, just like Qt in C++.

@notpeter notpeter added gpui GPUI rendering framework support and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Oct 22, 2024
@mrnugget
Copy link
Member

  • Additionally trying different examples, this is the message I get:

Seems to be a macOS problem: rust-windowing/winit#3931

@mrnugget
Copy link
Member

  • As such animation.py does not seem to cause any animation, just a black hello on green square. What I am reporting here is I suppose a bug of examples code.

Works here:

$ cd crates/gpui
$ cargo run --example animation

screenshot-2024-10-29-11 25 52

@krstp
Copy link
Author

krstp commented Nov 3, 2024

Did you run it out of the box on fresh env or being the zed developer, which I think you are, did you run it in your pre-existing development env? What I meant, it does not work on fresh install, imho some extra crates need to be added. When I find a minute I will try to look more into it.

@zed-industries zed-industries locked and limited conversation to collaborators Nov 3, 2024
@SomeoneToIgnore SomeoneToIgnore converted this issue into discussion #20140 Nov 3, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
bug [core label] gpui GPUI rendering framework support
Projects
None yet
Development

No branches or pull requests

4 participants