-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python bindings broken on Windows #215
Comments
Note that building python on Windows is currently disabled for CI builds and should be re-enabled once this is fixed. |
@timwoj I've seen that you've pushed some changes to the Broker bindings. Is this fixed? |
I don't believe so, but I can revert e7d9692 and check. |
No, still broken here: https://cirrus-ci.com/task/5149945408782336 |
After 5.0, we've wanted to revisit the need for Python bindings with WebSockets available (see #212). If we do end up deprecating (and later removing) the bindings, there's probably no point in fixing this. |
This may be something specific to Visual Studio 2019 and above, or it may not be. As part of #214, we discovered that the python bindings aren't getting loaded correctly on Windows. It appears that the DLL isn't being autoloaded when
import _broker
is called from the__init__.py
file for the broker module:This works correctly on macOS and Linux where it loads a shared object. There were some changes around DLL loading in Python 3.8, but I tested it on both 3.6 and 3.10 and it doesn't work on either of them.
The text was updated successfully, but these errors were encountered: