You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
zkg currently warns when a user var that a template feature declares required is not available, but then continues. The validation methods in the features currently check that values are actually present and non-empty, but they don't really need to — the fact that features already declared them required is enough.
We can simplify this by aborting where we currently warn. That means the validation code only has to do the kind of validation that's actually interesting, such as checking for a particular type, formatting, etc.
We can also simplify how the templating code currently derives substitution parameters from user vars: when a user var directly translates into a param, that can be done by default — no need for templates to do this explicitly.
The text was updated successfully, but these errors were encountered:
@bbannier, fyi — the first part of this is based directly on the comment in your Spicy template. I noticed the same thing today when I tweaked templates for the first time in a while.
zkg
currently warns when a user var that a template feature declares required is not available, but then continues. The validation methods in the features currently check that values are actually present and non-empty, but they don't really need to — the fact that features already declared them required is enough.We can simplify this by aborting where we currently warn. That means the validation code only has to do the kind of validation that's actually interesting, such as checking for a particular type, formatting, etc.
We can also simplify how the templating code currently derives substitution parameters from user vars: when a user var directly translates into a param, that can be done by default — no need for templates to do this explicitly.
The text was updated successfully, but these errors were encountered: