Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should "backtracking outside of &try scope" be a UsageError? #1564

Open
awelzel opened this issue Oct 4, 2023 · 1 comment
Open

Should "backtracking outside of &try scope" be a UsageError? #1564

awelzel opened this issue Oct 4, 2023 · 1 comment

Comments

@awelzel
Copy link
Contributor

awelzel commented Oct 4, 2023

Forgot to remove a backtrack() from a unit and eventually found a violation in the analyzer.log explaining the problem.

Would think this is an error that should make it into reporter.log and on stderr quickly (if not outright cause an exit) rather than be treated as a "violation". Might also be nice to detect this statically, but not sure if easy and/or possible even.

#fields ts      cause   analyzer_kind   analyzer_name   uid     fuid    id.orig_h       id.orig_p       id.resp_h  id.resp_p       failure_reason  failure_data
#types  time    string  string  string  string  string  addr    port    addr    port    string  string
1692782078.971564       violation       protocol        QUIC    CHhAvVGS1DHFjwGM9       -       xxx    yyy   443     backtracking outside of &try scope      \xcc\x00\x00\x00\x01\x10\x8...
@rsmmr
Copy link
Member

rsmmr commented Oct 5, 2023

Statically would be tricky, but yeah, makes sense to elevate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants